Skip to content

[cuDNN][cuDNN RNNv8 API] Fix math type behavior in cuDNN RNN#120277

Closed
eqy wants to merge 2 commits intomainfrom
eqy-patch-27
Closed

[cuDNN][cuDNN RNNv8 API] Fix math type behavior in cuDNN RNN#120277
eqy wants to merge 2 commits intomainfrom
eqy-patch-27

Conversation

@eqy
Copy link
Copy Markdown
Collaborator

@eqy eqy commented Feb 21, 2024

Adds back CUDNN_TENSOR_OP_MATH which was erroneously dropped by #115719

CC @malfet @ptrblck

cc @csarofeen @ptrblck @xwang233 @zou3519 @mikaylagawarecki

@eqy eqy added module: cudnn Related to torch.backends.cudnn, and CuDNN support module: rnn Issues related to RNN support (LSTM, GRU, etc) open source module: half Related to float16 half-precision floats topic: not user facing topic category labels Feb 21, 2024
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120277

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6578959 with merge base aae7ccd (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 21, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Tried to rebase and push PR #120277, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 21, 2024

@pytorchmergebot rebase -b main

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased eqy-patch-27 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout eqy-patch-27 && git pull --rebase)

@albanD albanD requested a review from drisspg February 22, 2024 16:16
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 22, 2024
@drisspg
Copy link
Copy Markdown
Contributor

drisspg commented Feb 22, 2024

https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_cudnn.sh

I wonder what would the effort but to have a some newer cudnn builds in ci

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 22, 2024

https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_cudnn.sh

I wonder what would the effort but to have a some newer cudnn builds in ci

The main effort would be tracking down all of the different paths (e.g., incl. windows) as attempted in #119710.

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 22, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased eqy-patch-27 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout eqy-patch-27 && git pull --rebase)

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 23, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 23, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cudnn Related to torch.backends.cudnn, and CuDNN support module: half Related to float16 half-precision floats module: rnn Issues related to RNN support (LSTM, GRU, etc) open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants