Skip to content

[cuDNN][cuDNN-frontend] Bump cuDNN version in tandem with cudnn-frontend#119710

Closed
eqy wants to merge 2 commits intopytorch:mainfrom
eqy:cudnn897frontend110
Closed

[cuDNN][cuDNN-frontend] Bump cuDNN version in tandem with cudnn-frontend#119710
eqy wants to merge 2 commits intopytorch:mainfrom
eqy:cudnn897frontend110

Conversation

@eqy
Copy link
Copy Markdown
Collaborator

@eqy eqy commented Feb 12, 2024 •
edited by pytorch-bot bot
Loading

CC @Skylion007

Checking if this seems to calm things down..,

cc @csarofeen @ptrblck @xwang233

@eqy eqy added module: cudnn Related to torch.backends.cudnn, and CuDNN support open source topic: not user facing topic category labels Feb 12, 2024
@eqy eqy requested a review from jeffdaily as a code owner February 12, 2024 20:43
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119710

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 5 Unrelated Failures

As of commit 89a3c7e with merge base 110919c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eqy eqy added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request labels Feb 12, 2024
Skylion007
Skylion007 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass.

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 12, 2024 •
edited
Loading

hmm, looks like we probably want to bump the CUDA 11 cuDNN version as well...

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 13, 2024

Interestingly it looks like the issue may only surface on certain devices (e.g., A10G) in the original PR, as it doesn't seem to be rerproducing on SM80...

@johnnynunez
Copy link
Copy Markdown
Contributor

johnnynunez commented Feb 13, 2024 •
edited
Loading

CC @Skylion007

Checking if this seems to calm things down..,

cc @csarofeen @ptrblck @xwang233

cudnn 9.0 is out and compatible with cuda 12
image
image

@ptrblck consider it because there are huge improvement on flash attention

malfet
malfet approved these changes Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't you have to do the corresponding update for conda builds (where cudnn is still not available).

Also, please make sure to update versions pypi depends on

pytorch/.github/scripts/generate_binary_build_matrix.py

Line 39 in c0e5cca

"nvidia-cudnn-cu11==8.7.0.84; platform_system == 'Linux' and platform_machine == 'x86_64' | "

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Feb 13, 2024

@atalman do you mind importing it internally and make sure it will work?
cc: @drisspg who did some cudnn_frontend updates recently

@drisspg
Copy link
Copy Markdown
Contributor

drisspg commented Feb 13, 2024

The cudnn-frontend update to 1.0.3 just landed internally yesterday and I am still letting it bake to see if anything comes up, what version does this bump it to?

@Skylion007
Copy link
Copy Markdown
Collaborator

Skylion007 commented Feb 14, 2024

The cudnn-frontend update to 1.0.3 just landed internally yesterday and I am still letting it bake to see if anything comes up, what version does this bump it to?

1.1.0

@johnnynunez
Copy link
Copy Markdown
Contributor

johnnynunez commented Feb 14, 2024 •
edited
Loading

v1.1.1
https://github.com/NVIDIA/cudnn-frontend/releases/tag/v1.1.1

@eqy
Copy link
Copy Markdown
Collaborator Author

eqy commented Feb 22, 2024

Closing as we've merged 1.1.1

@eqy eqy closed this Feb 22, 2024
@eqy eqy mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request module: cudnn Related to torch.backends.cudnn, and CuDNN support open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eqy @johnnynunez @malfet @drisspg @Skylion007