Skip to content

Update triton ROCm version to 6.0#117433

Closed
jithunnair-amd wants to merge 1 commit intopytorch:mainfrom
ROCm:update_triton_to_rocm6.0
Closed

Update triton ROCm version to 6.0#117433
jithunnair-amd wants to merge 1 commit intopytorch:mainfrom
ROCm:update_triton_to_rocm6.0

Conversation

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

@jithunnair-amd jithunnair-amd commented Jan 13, 2024

Related to PyTorch nightly wheels upgrade to ROCm6.0: #116983

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@jithunnair-amd jithunnair-amd requested a review from a team as a code owner January 13, 2024 07:13
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117433

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit 849b434 with merge base 302f931 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Jan 13, 2024
@jithunnair-amd jithunnair-amd added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 13, 2024
@jithunnair-amd
Copy link
Copy Markdown
Collaborator Author

@jeffdaily This change is also part of your CI upgrade PR #116270, but since that seems to have some MIOpen failures that might take longer to resolve, I think we should push this update separately to update the triton wheel ROCm versions to match other nightly wheels.

@jataylo
Copy link
Copy Markdown
Collaborator

jataylo commented Jan 17, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jan 24, 2024
Reverting [this commit](#117433) due to failures observed in wheel environment e.g:
```
ImportError: /tmp/torchinductor_root/triton/0/ebfa57c0b7b95873c96cad6f9bca148d/hip_utils.so: undefined symbol: hipGetDevicePropertiesR0600`
```

Will revert for now and investigate and aim to re-land this as part of #116270

Pull Request resolved: #118179
Approved by: https://github.com/jeffdaily, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants