Skip to content

Revert "Update triton ROCm version to 6.0"#118179

Closed
jataylo wants to merge 1 commit intomainfrom
revert-triton-60
Closed

Revert "Update triton ROCm version to 6.0"#118179
jataylo wants to merge 1 commit intomainfrom
revert-triton-60

Conversation

@jataylo
Copy link
Copy Markdown
Collaborator

@jataylo jataylo commented Jan 24, 2024

Reverting this commit due to failures observed in wheel environment e.g:

ImportError: /tmp/torchinductor_root/triton/0/ebfa57c0b7b95873c96cad6f9bca148d/hip_utils.so: undefined symbol: hipGetDevicePropertiesR0600`

Will revert for now and investigate and aim to re-land this as part of #116270

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @hongxiayang

Reverting this commit due to failures observed in wheel environment e.g `ImportError: /tmp/torchinductor_root/triton/0/ebfa57c0b7b95873c96cad6f9bca148d/hip_utils.so: undefined symbol: hipGetDevicePropertiesR0600`

Will revert for now and investigate and aim to re-land this as part of #116270
@jataylo jataylo requested a review from a team as a code owner January 24, 2024 09:35
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118179

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e522392 with merge base c5702a0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Jan 24, 2024
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@jeffdaily
Copy link
Copy Markdown
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the revert-triton-60 branch February 24, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants