Remove deprecated factory functions from Type.#11583
Closed
Conversation
Differential Revision: D9790187 Differential Version: 57609071
Differential Revision: D9792800 Differential Version: 57621323
Contributor
|
Blocked on #11489 ? |
gchanan
approved these changes
Sep 12, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
There might also be codegen we can remove...
Differential Revision: D9792800 Differential Version: 57641431
Differential Revision: D9790187 Differential Version: 57641656
Differential Revision: D9792800 Differential Version: 57641653
Contributor
|
what about here: pytorch/aten/src/ATen/function_wrapper.py Lines 1083 to 1092 in 739e6af |
Differential Revision: D9792800 Differential Version: 57648333
Differential Revision: D9790187 Differential Version: 57784244
Differential Revision: D9792800 Differential Version: 57784242
Differential Revision: D9792800 Differential Version: 57802525
Differential Revision: D9790187 Differential Version: 57805354
Differential Revision: D9792800 Differential Version: 57805356
Collaborator
|
@ezyang this seems mergeable |
Differential Revision: D9792800 Differential Version: 58423817
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 20, 2018
Summary: Pull Request resolved: pytorch/pytorch#11583 Reviewed By: SsnL Differential Revision: D9792800 fbshipit-source-id: 9af46d577911ff38647790169df66aa5d0379dd9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11583 Remove deprecated factory functions from Type. 💚
Differential Revision: D9792800