Move Type.h, Tensor.h, TensorMethods.h to core.#11489
Closed
gchanan wants to merge 8 commits intopytorch:masterfrom
Closed
Move Type.h, Tensor.h, TensorMethods.h to core.#11489gchanan wants to merge 8 commits intopytorch:masterfrom
gchanan wants to merge 8 commits intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
To do this, we check in the files, but still generate them (to a different location) and check that they match. This has the advantage of making it searchable while still ensuring they match what would be generated and can be easily refactored.
ff2aa38 to
5733455
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
cpuhrsch
reviewed
Sep 11, 2018
|
|
||
| static int CoreTestGlobal = 0; | ||
| int CoreTest() { | ||
| Tensor x; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
reviewed
Sep 11, 2018
| file_manager.check_all_files_written() | ||
| cuda_file_manager.check_all_files_written() | ||
|
|
||
| # check that generated files match source files |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Sep 11, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
I better hurry up with my patch...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this, we check in the files, but still generate them (to a different location) and check that they match.
This has the advantage of making it searchable while still ensuring they match what would be generated and can be easily refactored.