Skip to content

[Reland][Dynamo] Don't log compilation metrics for PyTorch unit tests#115571

Closed
davidberard98 wants to merge 1 commit intogh/davidberard98/250/basefrom
gh/davidberard98/250/head
Closed

[Reland][Dynamo] Don't log compilation metrics for PyTorch unit tests#115571
davidberard98 wants to merge 1 commit intogh/davidberard98/250/basefrom
gh/davidberard98/250/head

Conversation

@davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Dec 11, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 11, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115571

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b2d5f2e with merge base 5c0976f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

davidberard98 added a commit that referenced this pull request Dec 11, 2023
@davidberard98
[Reland][Dynamo] Don't log compilation metrics for PyTorch unit tests
6a9f0bb 
Reland # 115452

ghstack-source-id: f66f68c
Pull Request resolved: #115571
davidberard98
davidberard98 commented Dec 11, 2023
View reviewed changes
torch/_dynamo/convert_frame.py
code.co_name,
code.co_filename,
code.co_firstlineno,
cache_size.num_cache_entries_with_same_id_matched_objs,
Copy link
Contributor Author

@davidberard98 davidberard98 Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line is the merge conflict

@davidberard98 davidberard98 marked this pull request as ready for review December 11, 2023 20:01
@davidberard98 davidberard98 requested a review from a team as a code owner December 11, 2023 20:01
@davidberard98
Copy link
Contributor Author

davidberard98 commented Dec 11, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 11, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 11, 2023

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@davidberard98 davidberard98 added the topic: not user facing topic category label Dec 11, 2023
@davidberard98
Copy link
Contributor Author

davidberard98 commented Dec 11, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 11, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
@davidberard98 @guilhermeleobas
[Reland][Dynamo] Don't log compilation metrics for PyTorch unit tests (…
b6aebb3 
…pytorch#115571)

Reland pytorch#115452, which was reverted to simplify a merge conflict with pytorch#115386

Pull Request resolved: pytorch#115571
Approved by: https://github.com/yanboliang
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@davidberard98 @dmenig
[Reland][Dynamo] Don't log compilation metrics for PyTorch unit tests (…
f12f676 
…pytorch#115571)

Reland pytorch#115452, which was reverted to simplify a merge conflict with pytorch#115386

Pull Request resolved: pytorch#115571
Approved by: https://github.com/yanboliang
@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/250/head branch January 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidberard98 @pytorchmergebot @yanboliang