Skip to content

[Dynamo] Don't log compilation metrics for PyTorch unit tests#115452

Closed
yanboliang wants to merge 1 commit intopytorch:mainfrom
yanboliang:log
Closed

[Dynamo] Don't log compilation metrics for PyTorch unit tests#115452
yanboliang wants to merge 1 commit intopytorch:mainfrom
yanboliang:log

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Dec 8, 2023

@yanboliang yanboliang requested a review from a team as a code owner December 8, 2023 21:10
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115452

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d06098a with merge base 12d7ea1 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 8, 2023
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@davidberard98
Copy link
Contributor

@pytorchbot revert -c ghfirst -m "Merge conflict with #115385, which already landed in fbcode"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@yanboliang your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 11, 2023
…#115452)"

This reverts commit cd444aa.

Reverted #115452 on behalf of https://github.com/davidberard98 due to Merge conflict with #115385, which already landed in fbcode ([comment](#115452 (comment)))
pytorchmergebot pushed a commit that referenced this pull request Dec 12, 2023
…#115571)

Reland #115452, which was reverted to simplify a merge conflict with #115386

Pull Request resolved: #115571
Approved by: https://github.com/yanboliang
guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
…pytorch#115452)"

This reverts commit cd444aa.

Reverted pytorch#115452 on behalf of https://github.com/davidberard98 due to Merge conflict with pytorch#115385, which already landed in fbcode ([comment](pytorch#115452 (comment)))
guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
…pytorch#115452)"

This reverts commit cd444aa.

Reverted pytorch#115452 on behalf of https://github.com/davidberard98 due to Merge conflict with pytorch#115385, which already landed in fbcode ([comment](pytorch#115452 (comment)))
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants