[export] Enable verifier [2/n]#113075
Closed
zhxchen17 wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113075
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 3bb63ce with merge base eb54873 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
angelayi
approved these changes
Nov 6, 2023
| range_constraints: Dict[str, RangeConstraint] | ||
| equality_constraints: List[Tuple[Tuple[str, int], Tuple[str, int]]] | ||
| schema_version: int | ||
| example_inputs: Optional[Tuple[List[bytes], Dict[str, bytes]]] |
Contributor
Author
There was a problem hiding this comment.
removing this in schema
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 6, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
439bfdf to
a105a3b
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
a105a3b to
73cc9aa
Compare
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/executorch#1155 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Test Plan: CI Differential Revision: D51014944
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
73cc9aa to
7e750b1
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
7e750b1 to
b2086e7
Compare
b2086e7 to
71b9f0f
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
ff72f60 to
0ebc3cc
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
Summary: X-link: pytorch/executorch#1155 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Test Plan: CI Reviewed By: angelayi Differential Revision: D51014944
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 8, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
0ebc3cc to
3bb63ce
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #1155 X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944 fbshipit-source-id: 9a9e689ec9c8561a9c5cd4b6bd8836809ae5ff30
Contributor
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mergennachin
pushed a commit
to mergennachin/executorch-1
that referenced
this pull request
Nov 9, 2023
Summary: Due to pytorch/pytorch#113075 and pytorch#1155 Differential Revision: D51159878
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Test Plan: CI Differential Revision: D51014944 Pull Request resolved: pytorch#113075 Approved by: https://github.com/angelayi
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Since pytorch 2.1 release we've made some BC breaking changes to the serialized schema. We should update it in time for the 2.2 release. Some of the changes include: * #114371 - custom class objects / pybinded objects are no longer saved directly to the `ExportedProgram` structure. Instead, the name is serialized inside of the program, and the actual bytes are stored. in a separate location from the exported program, allowing it to be saved to a different location. * #111204 - `GraphSignature` structure changed and `call_spec` is removed from the `GraphModule` schema * #111407 - `loss_outout` -> `loss_output` * #113075 - `example_inputs` removed from the `ExportedProgram` structure (this originally did not store anything), `dialect` added to the `ExportedProgram` structure. * #113689 - tensor constants are now lifted as inputs to the graph, and their locations are stored in the `GraphSignature` * #114172 - removed `equality_constraints` and added a `SymExprHint` for all symbolic expressions. Pull Request resolved: #115712 Approved by: https://github.com/gmagogsfm
angelayi
added a commit
that referenced
this pull request
Dec 15, 2023
Since pytorch 2.1 release we've made some BC breaking changes to the serialized schema. We should update it in time for the 2.2 release. Some of the changes include: * #114371 - custom class objects / pybinded objects are no longer saved directly to the `ExportedProgram` structure. Instead, the name is serialized inside of the program, and the actual bytes are stored. in a separate location from the exported program, allowing it to be saved to a different location. * #111204 - `GraphSignature` structure changed and `call_spec` is removed from the `GraphModule` schema * #111407 - `loss_outout` -> `loss_output` * #113075 - `example_inputs` removed from the `ExportedProgram` structure (this originally did not store anything), `dialect` added to the `ExportedProgram` structure. * #113689 - tensor constants are now lifted as inputs to the graph, and their locations are stored in the `GraphSignature` * #114172 - removed `equality_constraints` and added a `SymExprHint` for all symbolic expressions. Pull Request resolved: #115712 Approved by: https://github.com/gmagogsfm
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
Since pytorch 2.1 release we've made some BC breaking changes to the serialized schema. We should update it in time for the 2.2 release. Some of the changes include: * pytorch#114371 - custom class objects / pybinded objects are no longer saved directly to the `ExportedProgram` structure. Instead, the name is serialized inside of the program, and the actual bytes are stored. in a separate location from the exported program, allowing it to be saved to a different location. * pytorch#111204 - `GraphSignature` structure changed and `call_spec` is removed from the `GraphModule` schema * pytorch#111407 - `loss_outout` -> `loss_output` * pytorch#113075 - `example_inputs` removed from the `ExportedProgram` structure (this originally did not store anything), `dialect` added to the `ExportedProgram` structure. * pytorch#113689 - tensor constants are now lifted as inputs to the graph, and their locations are stored in the `GraphSignature` * pytorch#114172 - removed `equality_constraints` and added a `SymExprHint` for all symbolic expressions. Pull Request resolved: pytorch#115712 Approved by: https://github.com/gmagogsfm
malfet
pushed a commit
that referenced
this pull request
Dec 18, 2023
Since pytorch 2.1 release we've made some BC breaking changes to the serialized schema. We should update it in time for the 2.2 release. Some of the changes include: * #114371 - custom class objects / pybinded objects are no longer saved directly to the `ExportedProgram` structure. Instead, the name is serialized inside of the program, and the actual bytes are stored. in a separate location from the exported program, allowing it to be saved to a different location. * #111204 - `GraphSignature` structure changed and `call_spec` is removed from the `GraphModule` schema * #111407 - `loss_outout` -> `loss_output` * #113075 - `example_inputs` removed from the `ExportedProgram` structure (this originally did not store anything), `dialect` added to the `ExportedProgram` structure. * #113689 - tensor constants are now lifted as inputs to the graph, and their locations are stored in the `GraphSignature` * #114172 - removed `equality_constraints` and added a `SymExprHint` for all symbolic expressions. Pull Request resolved: #115712 Approved by: https://github.com/gmagogsfm
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Since pytorch 2.1 release we've made some BC breaking changes to the serialized schema. We should update it in time for the 2.2 release. Some of the changes include: * pytorch#114371 - custom class objects / pybinded objects are no longer saved directly to the `ExportedProgram` structure. Instead, the name is serialized inside of the program, and the actual bytes are stored. in a separate location from the exported program, allowing it to be saved to a different location. * pytorch#111204 - `GraphSignature` structure changed and `call_spec` is removed from the `GraphModule` schema * pytorch#111407 - `loss_outout` -> `loss_output` * pytorch#113075 - `example_inputs` removed from the `ExportedProgram` structure (this originally did not store anything), `dialect` added to the `ExportedProgram` structure. * pytorch#113689 - tensor constants are now lifted as inputs to the graph, and their locations are stored in the `GraphSignature` * pytorch#114172 - removed `equality_constraints` and added a `SymExprHint` for all symbolic expressions. Pull Request resolved: pytorch#115712 Approved by: https://github.com/gmagogsfm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff.
Test Plan: CI
Differential Revision: D51014944
cc @avikchaudhuri @gmagogsfm @tugsbayasgalan @angelayi @suo @ydwu4