Enable verifier [2/n]#1155
Closed
zhxchen17 wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1155
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit fc6e7f9 with merge base b182621 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
963783a to
5cf6beb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/executorch#1155 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Test Plan: CI Differential Revision: D51014944
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
5cf6beb to
f251f84
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
f251f84 to
99c9b18
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
99c9b18 to
843546f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
843546f to
fd4d6fb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Differential Revision: D51014944
fd4d6fb to
aab0161
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
aab0161 to
afdb992
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/executorch#1155 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Test Plan: CI Reviewed By: angelayi Differential Revision: D51014944
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
afdb992 to
6a7e7de
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
6a7e7de to
a9dc95d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Nov 7, 2023
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
a9dc95d to
9b1381b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
Summary: X-link: pytorch/pytorch#113075 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Reviewed By: angelayi Differential Revision: D51014944
9b1381b to
fc6e7f9
Compare
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Nov 8, 2023
Summary: X-link: pytorch/executorch#1155 Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff. Test Plan: CI Reviewed By: angelayi Differential Revision: D51014944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014944 |
Contributor
|
This pull request has been merged in 6765b94. |
Contributor
Author
|
@mergennachin @larryliu0820 this PR requires a version bump of pytorch. I've tested some model run on my side and it seems to work. Let me know if I can help with anything further. |
mergennachin
pushed a commit
to mergennachin/executorch-1
that referenced
this pull request
Nov 9, 2023
Summary: Due to pytorch/pytorch#113075 and pytorch#1155 Differential Revision: D51159878
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#113075
Turn on verifier check for exportec program ctor. Note that this effectively detect a large surface of spec violations, so we also spend some time fixing them one by one in this diff.
Differential Revision: D51014944