Make mergebot work with review comments#107390
Closed
ZainRizvi wants to merge 1 commit intogh/ZainRizvi/8/basefrom
Closed
Make mergebot work with review comments#107390ZainRizvi wants to merge 1 commit intogh/ZainRizvi/8/basefrom
ZainRizvi wants to merge 1 commit intogh/ZainRizvi/8/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107390
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a69f3b3 with merge base aa9f6a4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ZainRizvi
commented
Aug 17, 2023
Comment on lines
+106
to
+113
| bodyText | ||
| createdAt | ||
| authorAssociation | ||
| editor { | ||
| login | ||
| } | ||
| databaseId | ||
| url |
Contributor
Author
There was a problem hiding this comment.
These give us all the fields expected by the _comment_from_node() function
clee2000
approved these changes
Aug 17, 2023
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #100406