Skip to content

Have mergebot properly handle review comments #100406

@ZainRizvi

Description

@ZainRizvi

If a user invokes pytorchbot merge while signing off on the PR, github classifies the comment as a "review comment" instead of a "direct comment."

Direct comments are correctly handled by mergebot, but not review comments. This has led to multiple occurrences where devs try to merge changes they're reviewing, but it fails

The ask:

Do one of the following:

  • Prevent pytorchbot from doing anything during a review comment, asking users to use a direct comment instead to merge their changes
  • (Preferred) Make pytorchbot handle merges from review comments as well. This will prob require searching the github graphql api for the reviewcomment

Additional context

This is a review comment:
Image

cc @kit1980 @huydhn @clee2000

Metadata

Metadata

Assignees

Labels

module: devxRelated to PyTorch contribution experience (HUD, pytorchbot)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions