-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Closed
Labels
module: devxRelated to PyTorch contribution experience (HUD, pytorchbot)Related to PyTorch contribution experience (HUD, pytorchbot)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
If a user invokes pytorchbot merge while signing off on the PR, github classifies the comment as a "review comment" instead of a "direct comment."
Direct comments are correctly handled by mergebot, but not review comments. This has led to multiple occurrences where devs try to merge changes they're reviewing, but it fails
The ask:
Do one of the following:
- Prevent pytorchbot from doing anything during a review comment, asking users to use a direct comment instead to merge their changes
- (Preferred) Make pytorchbot handle merges from review comments as well. This will prob require searching the github graphql api for the reviewcomment
Additional context
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
module: devxRelated to PyTorch contribution experience (HUD, pytorchbot)Related to PyTorch contribution experience (HUD, pytorchbot)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Type
Projects
Status
Done
