Avoid shadowing i, j vars in GeneralProposals test#10721
Closed
Maratyszcza wants to merge 1 commit intopytorch:masterfrom
Closed
Avoid shadowing i, j vars in GeneralProposals test#10721Maratyszcza wants to merge 1 commit intopytorch:masterfrom
Maratyszcza wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: - Fix compilation warning "declaration of 'i' shadows a previous local [-Werror=shadow-compatible-local]" Differential Revision: D9419688 fbshipit-source-id: 13285e39094be61fb9c2edb3614c6d3253f25416
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Aug 21, 2018
* upstream/master: (147 commits) Support Loading to GPU (pytorch#10710) More changes for hidden visibility (pytorch#10692) Add arguments __repr__ in Distribution base class Add util function from core type to dtype (pytorch#10716) Make ONNX_ATEN_FALLBACK as internal default option Set the BUILD_ENVIRONMENT variable before installing sccache. (pytorch#10640) Avoid shadowing i, j vars in GeneralProposals test (pytorch#10721) Move THNN Reduction to ATen/core. (pytorch#10703) Completely remove build_aten and use_aten (pytorch#10469) Make empty list literals construct empty Tensor[] (pytorch#10705) Soumith's last few patches to v0.4.1 Fix issues link in Caffe2 readme (pytorch#10711) Update the onnx Gemm op to FC/FCTransposed logic in caffe2 onnx backend (pytorch#10108) Adding ATEN_NO_TEST option to root level cmake for propogation to aten Allow method-style casts on tensors (pytorch#10641) Fix pytorch#10698 build failure (pytorch#10704) Add support for Log() Add a bisect percentile operator (pytorch#10563) Fix EnsureCPUOutputOp (pytorch#10651) Nomnigraph - rename some APIs that invole Subtree to Subgraph (pytorch#10551) ...
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10721 - Fix compilation warning "declaration of 'i' shadows a previous local [-Werror=shadow-compatible-local]" Reviewed By: newstzpz Differential Revision: D9419688 fbshipit-source-id: 76efc3688782ce4ead3c89e7069211736febfac2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: - Fix compilation warning "declaration of 'i' shadows a previous local [-Werror=shadow-compatible-local]"
Differential Revision: D9419688