[jit][script] Make empty list literals construct empty Tensor[]#10705
Closed
[jit][script] Make empty list literals construct empty Tensor[]#10705
Conversation
Member
Author
|
I'm concerned that the error msg is confusing: Should I add special casing for reporting this error? (e.g. if we're trying to assign to a tensor list and get a type error, mention that empty lists are constructed as tensor lists). |
zdevito
approved these changes
Aug 20, 2018
Contributor
zdevito
left a comment
There was a problem hiding this comment.
Looks good. Custom error is useful until we get this working better.
torch/csrc/jit/script/compiler.cpp
Outdated
| throw ErrorReport(tree) << "Empty list literals not allowed. " | ||
| << "Use _construct_empty_foo_list() instead. " | ||
| << "`foo` can be `int`, `float` or `tensor`"; | ||
| // If this is an empty list literal `[]`, construct an empty Tensor[] |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
michaelsuo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Aug 21, 2018
* upstream/master: (147 commits) Support Loading to GPU (pytorch#10710) More changes for hidden visibility (pytorch#10692) Add arguments __repr__ in Distribution base class Add util function from core type to dtype (pytorch#10716) Make ONNX_ATEN_FALLBACK as internal default option Set the BUILD_ENVIRONMENT variable before installing sccache. (pytorch#10640) Avoid shadowing i, j vars in GeneralProposals test (pytorch#10721) Move THNN Reduction to ATen/core. (pytorch#10703) Completely remove build_aten and use_aten (pytorch#10469) Make empty list literals construct empty Tensor[] (pytorch#10705) Soumith's last few patches to v0.4.1 Fix issues link in Caffe2 readme (pytorch#10711) Update the onnx Gemm op to FC/FCTransposed logic in caffe2 onnx backend (pytorch#10108) Adding ATEN_NO_TEST option to root level cmake for propogation to aten Allow method-style casts on tensors (pytorch#10641) Fix pytorch#10698 build failure (pytorch#10704) Add support for Log() Add a bisect percentile operator (pytorch#10563) Fix EnsureCPUOutputOp (pytorch#10651) Nomnigraph - rename some APIs that invole Subtree to Subgraph (pytorch#10551) ...
apaszke
reviewed
Aug 23, 2018
| as_simple_value->type()->kind() == TypeKind::ListType) { | ||
| errMsg << "\n. (Note: empty lists are constructed as Tensor[]; " | ||
| << "if you want an empty list of a different type, " | ||
| << "use `_construct_empty_foo_list`, " |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: This will make the common case more natural (no need to do `_construct_empty_tensor_list()`) Pull Request resolved: pytorch#10705 Differential Revision: D9411622 Pulled By: michaelsuo fbshipit-source-id: 2d91fbc5787426748d6e1c8e7bbeee737544dc96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the common case more natural (no need to do
_construct_empty_tensor_list())