Workaround for Cuda9.2 and GCC7 compilation errors#10510
Closed
mingzhe09088 wants to merge 1 commit intopytorch:masterfrom
mingzhe09088:nvcc-workaround
Closed
Workaround for Cuda9.2 and GCC7 compilation errors#10510mingzhe09088 wants to merge 1 commit intopytorch:masterfrom mingzhe09088:nvcc-workaround
mingzhe09088 wants to merge 1 commit intopytorch:masterfrom
mingzhe09088:nvcc-workaround
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
reviewed
Aug 15, 2018
Contributor
orionr
left a comment
There was a problem hiding this comment.
I don't think the Windows failure is caused by you, so this looks clean! Well done.
orionr
approved these changes
Aug 15, 2018
ezyang
reviewed
Aug 15, 2018
| // This is a workaround for CUDA9.2 and GCC7 | ||
| #if defined(CUDART_VERSION) && CUDART_VERSION >= 9020 && __GNUC__ >= 7 | ||
| #define OP_SINGLE_ARG(type, name, variable, default) \ | ||
| variable(this->template GetSingleArgument<type>(name, (default))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
Merge this ASAP, you can fix the nit later if you think it's a good idea. |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Breaking out of pytorch#8338 This PR is a workaround for a bug with CUDA9.2 + GCC7. Here is the error this PR fixed: .../pytorch/caffe2/operators/elementwise_ops.h: In constructor ‘caffe2::BinaryElementwiseWithArgsOp<InputTypes, Context, Functor, OutputTypeMap>::BinaryElementwiseWithArgsOp(const caffe2::OperatorDef&, caffe2::Workspace*)’: .../pytorch/caffe2/operators/elementwise_ops.h:106:189: error: ‘GetSingleArgument<bool>’ is not a member of ‘caffe2::BinaryElementwiseWithArgsOp<InputTypes, Context, Functor, OutputTypeMap>’ BinaryElementwiseWithArgsOp(const OperatorDef& operator_def, Workspace* ws) Pull Request resolved: pytorch#10510 Reviewed By: orionr Differential Revision: D9319742 Pulled By: mingzhe09088 fbshipit-source-id: ce59e3db14539f071f3c20301e77ca36a6fc3f81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking out of #8338
This PR is a workaround for a bug with CUDA9.2 + GCC7.
Here is the error this PR fixed:
.../pytorch/caffe2/operators/elementwise_ops.h: In constructor ‘caffe2::BinaryElementwiseWithArgsOp<InputTypes, Context, Functor, OutputTypeMap>::BinaryElementwiseWithArgsOp(const caffe2::OperatorDef&, caffe2::Workspace*)’:
.../pytorch/caffe2/operators/elementwise_ops.h:106:189: error: ‘GetSingleArgument’ is not a member of ‘caffe2::BinaryElementwiseWithArgsOp<InputTypes, Context, Functor, OutputTypeMap>’
BinaryElementwiseWithArgsOp(const OperatorDef& operator_def, Workspace* ws)