Add intrinsic support for external_input/output to nomnigraph#10100
Closed
bwasti wants to merge 1 commit intopytorch:masterfrom
Closed
Add intrinsic support for external_input/output to nomnigraph#10100bwasti wants to merge 1 commit intopytorch:masterfrom
bwasti wants to merge 1 commit intopytorch:masterfrom
Conversation
24b31cc to
5efb4af
Compare
5efb4af to
5e8ee14
Compare
…h#10100) Summary: Pull Request resolved: pytorch#10100 nomnigraph has until this point tried to ignore external input and output, as they aren't very well defined (does order matter?). but for DCE and some of Keren's work they are becoming necessary. I went ahead and added this to the core nomnigraph converter Reviewed By: yinghai Differential Revision: D9105487 fbshipit-source-id: e0759373d737444f01275c4a84c64e9e8b7cdae0
5e8ee14 to
84a7bba
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…h#10100) Summary: Pull Request resolved: pytorch#10100 nomnigraph has until this point tried to ignore external input and output, as they aren't very well defined (does order matter?). but for DCE and some of Keren's work they are becoming necessary. I went ahead and added this to the core nomnigraph converter Reviewed By: yinghai Differential Revision: D9105487 fbshipit-source-id: a2e10e3cc84515611d6ab7d4bc54cf99b77729c0
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 17, 2018
…10598) Summary: #10100 recently take external input/output in nomnigraph. This PR makes adjust to 0. Relax some of the conditions on external input 1. Update NNModule inputs/outputs when pruning the input/output. 2. Avoiding copying external input/output as nomnigraph already takes care of it. Pull Request resolved: #10598 Reviewed By: bwasti Differential Revision: D9371730 Pulled By: yinghai fbshipit-source-id: 9273be5041dc4cc8585587f47cb6721e518a06a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: nomnigraph has until this point tried to ignore external input and output, as they aren't very well defined (does order matter?). but for DCE and some of Keren's work they are becoming necessary. I went ahead and added this to the core nomnigraph converter
Differential Revision: D9105487