Skip to content

[Caffe2] Fix subgraph cutting wrt recent external_input change in nomnigraph#10598

Closed
yinghai wants to merge 2 commits intopytorch:masterfrom
yinghai:fix_sub
Closed

[Caffe2] Fix subgraph cutting wrt recent external_input change in nomnigraph#10598
yinghai wants to merge 2 commits intopytorch:masterfrom
yinghai:fix_sub

Conversation

@yinghai
Copy link
Contributor

@yinghai yinghai commented Aug 16, 2018

#10100 recently take external input/output in nomnigraph. This PR makes adjust to
0. Relax some of the conditions on external input

  1. Update NNModule inputs/outputs when pruning the input/output.
  2. Avoiding copying external input/output as nomnigraph already takes care of it.

@yinghai yinghai added the caffe2 label Aug 16, 2018
@yinghai yinghai requested a review from bwasti August 16, 2018 22:36
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yinghai yinghai changed the title [Caffe2] Fix subgraph cutting wrt recent extenral_input change in nomnigraph [Caffe2] Fix subgraph cutting wrt recent external_input change in nomnigraph Aug 16, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yinghai yinghai deleted the fix_sub branch August 17, 2018 16:44
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants