[Helion + torch.compile] Add store/load transform hooks and prologue/epilogue fusion codegen#1724
Merged
[Helion + torch.compile] Add store/load transform hooks and prologue/epilogue fusion codegen#1724
Conversation
This was referenced Mar 16, 2026
Merged
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
…rameter plumbing Add infrastructure for prologue/epilogue fusion in generated Triton code: - store_transform/load_transform hooks in memory_ops for hl.store/hl.load - Extra params, removed args, and protected arg names in codegen pipeline - dim_index_exprs on SubscriptIndexing for epilogue fusion offsets - _ensure_inductor_fusion_config() to enable fusion via config_patches stack-info: PR: #1724, branch: yf225/stack/71
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
…rameter plumbing Add infrastructure for prologue/epilogue fusion in generated Triton code: - store_transform/load_transform hooks in memory_ops for hl.store/hl.load - Extra params, removed args, and protected arg names in codegen pipeline - dim_index_exprs on SubscriptIndexing for epilogue fusion offsets - _ensure_inductor_fusion_config() to enable fusion via config_patches stack-info: PR: #1724, branch: yf225/stack/71
yf225
added a commit
that referenced
this pull request
Mar 17, 2026
…rameter plumbing Add infrastructure for prologue/epilogue fusion in generated Triton code: - store_transform/load_transform hooks in memory_ops for hl.store/hl.load - Extra params, removed args, and protected arg names in codegen pipeline - dim_index_exprs on SubscriptIndexing for epilogue fusion offsets - _ensure_inductor_fusion_config() to enable fusion via config_patches stack-info: PR: #1724, branch: yf225/stack/71 # Conflicts: # helion/_compiler/generate_ast.py
shunting314
reviewed
Mar 19, 2026
Contributor
shunting314
left a comment
There was a problem hiding this comment.
maybe you did in a later PR but in high level how to you pass in the load/store transform and extra params?
shunting314
reviewed
Mar 19, 2026
yf225
added a commit
that referenced
this pull request
Mar 19, 2026
…rameter plumbing Add infrastructure for prologue/epilogue fusion in generated Triton code: - store_transform/load_transform hooks in memory_ops for hl.store/hl.load - Extra params, removed args, and protected arg names in codegen pipeline - dim_index_exprs on SubscriptIndexing for epilogue fusion offsets - _ensure_inductor_fusion_config() to enable fusion via config_patches stack-info: PR: #1724, branch: yf225/stack/71 # Conflicts: # helion/_compiler/generate_ast.py
Contributor
Author
Yes I now merged them into the same PR (this one), with this high-level flow:
|
yf225
added a commit
that referenced
this pull request
Mar 19, 2026
…rameter plumbing Add infrastructure for prologue/epilogue fusion in generated Triton code: - store_transform/load_transform hooks in memory_ops for hl.store/hl.load - Extra params, removed args, and protected arg names in codegen pipeline - dim_index_exprs on SubscriptIndexing for epilogue fusion offsets - _ensure_inductor_fusion_config() to enable fusion via config_patches stack-info: PR: #1724, branch: yf225/stack/71 # Conflicts: # helion/_compiler/generate_ast.py
shunting314
reviewed
Mar 20, 2026
Contributor
|
@claude review this PR. Try to focus on making corner cases covered and make the integration between different components clean |
yf225
commented
Mar 20, 2026
Contributor
Author
yf225
left a comment
There was a problem hiding this comment.
[Claude Review] Overall: well-structured PR with clean callback pattern for store/load transforms. See inline comments for corner cases and integration concerns.
shunting314
approved these changes
Mar 20, 2026
jansel
approved these changes
Mar 22, 2026
…epilogue fusion codegen stack-info: PR: #1724, branch: yf225/stack/71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[Helion + torch.compile] Add store/load transform hooks and prologue/epilogue fusion codegen