[Helion + torch.compile] Enable torch.compile fusion tests#1727
Merged
Conversation
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
This was referenced Mar 16, 2026
Merged
Merged
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 16, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
commented
Mar 17, 2026
| (e.g. when a compiled function invokes multiple Helion kernels), each | ||
| layer passes config_patches through to the next without crashing. | ||
| """ | ||
| if os.environ.get("_WIP_DEV_ONLY_HELION_TORCH_COMPILE_FUSION", "0") != "1": |
Contributor
Author
There was a problem hiding this comment.
This _WIP_DEV_ONLY_HELION_TORCH_COMPILE_FUSION env var already exists and is temporary - after this PR is landed, I plan to remove this env var and switch the Helion + torch.compile integration to use the newly added HOP approach, and then add allow_torch_compile_fusion field to Helion kernel settings to control whether to do prologue/epilogue fusion.
yf225
added a commit
that referenced
this pull request
Mar 17, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 17, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 17, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 17, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
yf225
added a commit
that referenced
this pull request
Mar 17, 2026
- Replace unconditional `self.skipTest` with `requires_torch_version("2.11")`
guard, now that the required PyTorch-side changes have landed
- Update `expected_num_kernels` values across ~60 tests to reflect
reduced kernel counts from prologue/epilogue fusion
- Un-skip 3 previously disabled tests:
`test_autotune_no_fusion_final_has_fusion`,
`test_inductor_output_code_has_helion_generated_triton_kernel`,
`test_symint_return_from_tensor_shape`
stack-info: PR: #1727, branch: yf225/stack/74
jansel
approved these changes
Mar 20, 2026
Contributor
jansel
left a comment
There was a problem hiding this comment.
Make sure to remove the monkey patching when it is not needed. Doesn't seem ideal.
stack-info: PR: #1727, branch: yf225/stack/74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.