Fix error message in float8 FSDP utils#1423
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1423
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0d7abe6 with merge base 9472a17 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
thanks and welcome Daniel, I added you to our contributor list so you don't need approval to run CI |
vkuzo
approved these changes
Dec 17, 2024
vkuzo
left a comment
Contributor
There was a problem hiding this comment.
thanks! Good to go after CI is green
amdfaa
pushed a commit
that referenced
this pull request
Jan 10, 2025
fix error message in float8 fsdp utils Co-authored-by: Daniel Vega-Myhre <danvm@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1108
Error message should say
"Only supports dynamic scaling".