Skip to content

Assertion information on precompute_float8_dynamic_scale_for_fsdp is misleading  #1108

@goldhuang

Description

@goldhuang

https://github.com/pytorch/ao/blob/main/torchao/float8/fsdp_utils.py#L44-L48

Should it be raise NotImplementedError("Only supports dynamic scaling")?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions