Skip to content

feat: support cumsum dynamo converter#2403

Merged
zewenli98 merged 2 commits intopytorch:mainfrom
zewenli98:cumsum_dynamo_converter
Oct 31, 2023
Merged

feat: support cumsum dynamo converter#2403
zewenli98 merged 2 commits intopytorch:mainfrom
zewenli98:cumsum_dynamo_converter

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

@zewenli98 zewenli98 commented Oct 18, 2023

Description

Support cumsum dynamo converter. This is a part of slice converter.

Fixes part of #2215

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Oct 18, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Oct 18, 2023
@github-actions github-actions bot requested a review from narendasan October 18, 2023 01:03
@apbose apbose mentioned this pull request Oct 23, 2023
Closed
@zewenli98 zewenli98 requested a review from gs-olive October 24, 2023 22:54
gs-olive
gs-olive reviewed Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, otherwise looks good!

@zewenli98
Copy link
Copy Markdown
Collaborator Author

zewenli98 commented Oct 25, 2023

Thanks for the comments! They have been fixed!

@zewenli98 zewenli98 requested a review from gs-olive October 25, 2023 21:05
@zewenli98 zewenli98 force-pushed the cumsum_dynamo_converter branch from 48feb0c to 8373eb1 Compare October 26, 2023 00:51
gs-olive
gs-olive approved these changes Oct 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please rebase once #2418 is merged, and then ensure this PR also passes all of CI.

@zewenli98 zewenli98 force-pushed the cumsum_dynamo_converter branch from 8373eb1 to 941b04a Compare October 30, 2023 19:43
@zewenli98
Copy link
Copy Markdown
Collaborator Author

zewenli98 commented Oct 30, 2023

Got errors:

FAILED models/test_export_serde.py::test_base_full_compile - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_base_full_compile_multiple_outputs - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_base_full_compile_save_load - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_hybrid_relu_fallback - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_resnet18_save_load - KeyError: 'parameter name can\'t contain "."'

Can we merge it now? or waiting for a fix to this bug?

@gs-olive
Copy link
Copy Markdown
Contributor

gs-olive commented Oct 30, 2023

I think it can be merged while that fix is in progress, since it passes all of the newly added tests in CI and none of those models would invoke this specific converter.

@zewenli98 zewenli98 merged commit f617898 into pytorch:main Oct 31, 2023
gs-olive pushed a commit that referenced this pull request Dec 5, 2023
@zewenli98 @gs-olive
feat: support cumsum dynamo converter (#2403)
a2c2532
gs-olive pushed a commit that referenced this pull request Dec 5, 2023
@zewenli98 @gs-olive
feat: support cumsum dynamo converter (#2403)
5770e00
@gs-olive gs-olive mentioned this pull request Dec 5, 2023
Merged
@zewenli98 zewenli98 deleted the cumsum_dynamo_converter branch January 12, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan Awaiting requested review from narendasan

1 more reviewer

@gs-olive gs-olive gs-olive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zewenli98 @gs-olive @facebook-github-bot