Skip to content

fix: type error in embedding_bag#2418

Merged
zewenli98 merged 1 commit intopytorch:mainfrom
zewenli98:fix_embedding_bag_dynamo_converter
Oct 30, 2023
Merged

fix: type error in embedding_bag#2418
zewenli98 merged 1 commit intopytorch:mainfrom
zewenli98:fix_embedding_bag_dynamo_converter

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

@zewenli98 zewenli98 commented Oct 27, 2023

Description

There's a type error bug in embedding_bag implementation. This is a fix to the PR #2395

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 27, 2023
@zewenli98 zewenli98 self-assigned this Oct 27, 2023
gs-olive
gs-olive approved these changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and seems to be validated via CI. Approved, pending CI passes.

@gs-olive gs-olive mentioned this pull request Oct 30, 2023
Merged
7 tasks
@zewenli98 zewenli98 merged commit 27a9f6d into pytorch:main Oct 30, 2023
@zewenli98 zewenli98 deleted the fix_embedding_bag_dynamo_converter branch January 12, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gs-olive gs-olive gs-olive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zewenli98 @gs-olive @facebook-github-bot