Skip to content

Full Support for Bot API 9.2 #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 19 commits into from
Sep 13, 2025
Merged

Full Support for Bot API 9.2 #4911

Bibo-Joshi merged 19 commits into from
Sep 13, 2025

Conversation

@aelkheir
Copy link
Member

@aelkheir aelkheir commented Aug 16, 2025 •
edited
Loading

Closes #4910

Check-list for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy

  • Created a PR to remove functionality deprecated in the previous Bot API release (see here)

  • New Classes

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as keyword-only

  • Added New Shortcuts

    • In telegram.Chat & telegram.User for all methods that accept chat/user_id
    • In telegram.Message for all methods that accept chat_id and message_id
    • For new telegram.Message shortcuts: Added quote argument if methods accept reply_to_message_id
    • In telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If Relevant

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Linked new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added new message types to telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst (including the badge) and telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Aug 21, 2025
aelkheir and others added 12 commits August 26, 2025 18:30
@aelkheir
Add classes SuggestedPost[Parameters/Price]. (#4912)
a8b6ed7
@Bibo-Joshi
https://t.me/bot_api_changes/258
3451786
@Poolitzer @Bibo-Joshi
Feat: Added can_manage_dm and paid post (#4918)
90989a2 
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@aelkheir
Add classes SuggestedPost[Declined,Paid,Refunded] (#4921)
32c1a85
@harshil21 @Bibo-Joshi
API 9.2 Suggested Post Methods (#4916)
d5f8c34 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@Bibo-Joshi
Merge branch 'master' into api-9.2-central
a8b8aea
@aelkheir
API 9.2 SuggestedPost[Info,Approved,ApprovalFailed] (#4931)
de80172
@Bibo-Joshi
Add Parameter can_manage_direct_messages to promote_chat_member (#…
cfc6ad0 
…4935)
@Bibo-Joshi
Add Parameter message_thread_id to send_paid_media (#4936)
b318594
@aelkheir
Use regular str annotation for currency and state
2ac87a8
@aelkheir
Fix test_official check of DirectMessagesTopic.user
5b15b3c 
hope i didn't interupt, Hinrich :)
@Bibo-Joshi
Merge branch 'master' into api-9.2-central
0b26b5f
@Bibo-Joshi Bibo-Joshi merged commit 068ee7e into master Sep 13, 2025
32 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api-9.2-central branch September 13, 2025 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2025
harshil21
harshil21 reviewed Sep 22, 2025
View reviewed changes
src/telegram/_reply.py
message_id: int,
chat_id: Optional[Union[int, str]] = None,
allow_sending_without_reply: ODVInput[bool] = DEFAULT_NONE,
checklist_task_id: Optional[int] = None,
Copy link
Member

@harshil21 harshil21 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change @aelkheir @Bibo-Joshi

should be added to the end of the parameter list

Copy link
Member

@Bibo-Joshi Bibo-Joshi Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, we missed that. Maybe we should change it to make it non breaking. With the infinite retry bug we would then have two bugs for a bug fix release

Copy link
Member

@harshil21 harshil21 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would changing the order of the argument again make it breaking again 🤔

we could just accept it was breaking and announce as such in the channel

Copy link
Member Author

@aelkheir aelkheir Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to change it back to last position.

Either way we'll break users' code, we'll just be breaking a lesser amount of code assuming a lesser proportion of users updated since the last release

Copy link
Member

@Bibo-Joshi Bibo-Joshi Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @aelkheir on this ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

@harshil21 harshil21 harshil21 left review comments

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Full Support for Bot API 9.2

5 participants

@aelkheir @Bibo-Joshi @harshil21 @Poolitzer