-
Notifications
You must be signed in to change notification settings - Fork 6k
Add classes SuggestedPost[Parameters/Price].
#4912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things here and there, but overall looks good
This reverts commit 94e8ffa. Conflicts: src/telegram/_suggestedpost.py
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add, good work 🥳
|
should be good to merge after merge conflicts are resolved |
…d-post-params/price
|
sorry and thanks for the note. i was oblivious of this happening :) |
Check-list for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can ignore this passage)
Checked the Bot API specific sections of the Stability Policy
Created a PR to remove functionality deprecated in the previous Bot API release (see here)
New Classes
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas keyword-onlyAdded New Shortcuts
telegram.Chat&telegram.Userfor all methods that acceptchat/user_idtelegram.Messagefor all methods that acceptchat_idandmessage_idtelegram.Messageshortcuts: Addedquoteargument if methods acceptreply_to_message_idtelegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf Relevant
telegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachment_extbot.pybot_methods.rstAPI 9.2 Items:
Suggested Posts