Autogenerate "Shortcuts" admonitions #3529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..versionchanged with note "Returns a tuple instead of a list." It should be right above the Args like other ..version notes. This way the admonitions will be inserted correctly.
Bibo-Joshi
reviewed
Feb 3, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good overall :)
Bibo-Joshi
reviewed
Feb 3, 2023
Bibo-Joshi
approved these changes
Feb 3, 2023
Bibo-Joshi
added a commit
that referenced
this pull request
Feb 5, 2023
…3515, #3523, #3498, #3529) Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Shivam Saini <51438830+shivamsn97@users.noreply.github.com> Co-authored-by: Aditya Yadav <adityayadav11082@gmail.com> Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com> Co-authored-by: Crsi <47722349+CrsiX@users.noreply.github.com> Co-authored-by: poolitzer <github@poolitzer.eu> Co-authored-by: Aditya <clot27@apx_managed.vanilla>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3496 (last part of it; see also #3501 and #3523 that address the same issue): automatically generates "Shortcuts" admonitions for
Botmethods and removes manual ones.