Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

As suggested in https://t.me/c/1494805131/32127. Build will be up soonish on rtd.

URLs seem to be unchanged.

Before a merge, I want to test if this would imply any changes for rulesbot.

@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Jan 5, 2023
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer January 5, 2023 15:35
@Poolitzer
Copy link
Member

@Bibo-Joshi And we should check search

@Bibo-Joshi
Copy link
Member Author

Both search and rulesbot-search (which are basically the same thing, IG) seem to work fine :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to drop the prefixes even for the modules?

@Bibo-Joshi
Copy link
Member Author

Do we want to drop the prefixes even for the modules?

For telegram.{error, request, constants, …} I kept them so that it's clear at first glance how to import them. Is that what you mean?

@harshil21
Copy link
Member

@Bibo-Joshi yes

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you, looks perfect.

@Bibo-Joshi Bibo-Joshi requested a review from harshil21 January 6, 2023 07:42
@Bibo-Joshi Bibo-Joshi merged commit 91aba8b into doc-fixes Jan 10, 2023
@Bibo-Joshi Bibo-Joshi deleted the doc-no-prefixes branch January 10, 2023 16:49
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 10, 2023
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants