Skip to content

Conversation

@shivamsn97
Copy link
Contributor

Added copy button on docs using sphinx-copybutton (https://sphinx-copybutton.readthedocs.io/en/latest/)

@shivamsn97 shivamsn97 changed the title Added copy button in docs (#3486) Added copy button in docs Jan 7, 2023
Copy link
Member

@lemontree210 lemontree210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I tried building the docs locally and it does add the copy button to all code snippets)

@lemontree210 lemontree210 linked an issue Jan 7, 2023 that may be closed by this pull request
@lemontree210 lemontree210 added the ⚙️ documentation affected functionality: documentation label Jan 7, 2023
@lemontree210

This comment was marked as resolved.

@lemontree210 lemontree210 changed the base branch from master to doc-fixes January 7, 2023 15:23
@lemontree210
Copy link
Member

lemontree210 commented Jan 7, 2023

The base branch should be doc-fixes for this PR. When I changed the base branch it obviously messed up a lot of things :)

I guess you can rebase or just create a new PR, this time creating your local branch off doc-fixes, not master, then applying commit 20e9c30 with git cherry-pick. Whatever is easier.

(Unless my more experienced colleagues correct me :))

@shivamsn97
Copy link
Contributor Author

Okay, I will make a new PR to the doc-fixes branch. Closing this PR for now.

@shivamsn97 shivamsn97 closed this Jan 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCUMENTATION] Add copy button/icon to code snippets in docs

7 participants