Upload GH action built docs as Artifacts #3468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
Jan 3, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Also a nice idea! TBH I guess the use case is not overly big, but neither is the effort 🙃
Bibo-Joshi
approved these changes
Jan 3, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! As said above, even if the advantage may not be huge, I see no downsides of this change. I'll give the others a chance to chime in if they see the need and merge on thursday evening otherwise :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploads the built docs from the workflow run so it is easy to see the rendered html pages without building the docs again locally.
Docs on artifacts: https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts
How to view the artifact? Click on the "Details" of Test Doc Build -> Summary (left panel) -> scroll down and download the artifact