Skip to content

Conversation

@clot27
Copy link
Member

@clot27 clot27 commented Jan 2, 2023

Closes #3454

@clot27 clot27 requested review from Bibo-Joshi and harshil21 January 2, 2023 18:01
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more docs-nitpicking 😬

@harshil21 harshil21 added this to the v20.1 milestone Jan 2, 2023
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit 19302bc into master Jan 4, 2023
@Bibo-Joshi Bibo-Joshi deleted the post-stop branch January 4, 2023 15:48
@djmattyg007
Copy link

Wow, thank you everyone for such a fast response ❤️

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Send message in shutdown handler

6 participants