Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

  • Update docstring of restrict_chat_members argument chat_permission following official API docs
  • Update docstring of send_invoices argument provider_data following official API docs

@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Jun 28, 2020
days or less than 30 seconds from the current time, they are considered to be
restricted forever.
permissions (:class:`telegram.ChatPermissions`): New user permissions.
permissions (:class:`telegram.ChatPermissions`): A JSON-serialized object for new user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But uhm, in our context, it would be a JSON- deserialized Telegram class/object. Since we convert it from the string to our own object.

Copy link
Member Author

@Bibo-Joshi Bibo-Joshi Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just followed the convention to copy official docs. We have a bunch of similar docstrings … I'm fairly sure that passing json data would indeed also work

Bibo-Joshi and others added 5 commits July 15, 2020 22:28
* Fix PicklePersistence.flush() with only bot_data (#2017)

* Update pylint in pre-commit to fix CI (#2018)

* Add Filters.via_bot (#2009)

* feat: via_bot filter

also fixing a small mistake in the empty parameter of the user filter and improve docs slightly

* fix: forgot to set via_bot to None

* fix: redoing subclassing to copy paste solution

* Cosmetic changes

Co-authored-by: Hinrich Mahler <hinrich.mahler@freenet.de>

* Update CHANGES.rst

Fixed Typo

Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
Replaced RegexHandler with MessageHandler, since the former is deprecated
@Bibo-Joshi Bibo-Joshi added this to the 13.0 milestone Aug 4, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

forgot the hard wrap is at 99 chars, not 100!
fixed a few spelling mistakes too.
True, False, None are now rendered with ``bool`` wherever they weren't in telegram and telegram.ext classes.
As usual, docs were cross-checked with official tg api docs.
As usual, docs were cross-checked with official tg api docs.
Mostly just added hyperlinks. And fixed message length doc.

As usual, docs were cross-checked with official tg api docs.
Didn't bother changing too much since this seems to be a custom implementation.
As usual, cross-checked with official bot api docs.
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is good!

@Bibo-Joshi Bibo-Joshi merged commit a0720b9 into master Aug 24, 2020
@Bibo-Joshi Bibo-Joshi deleted the doc-fixes branch August 24, 2020 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants