-
Notifications
You must be signed in to change notification settings - Fork 6k
Doc fixes #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fixes #2008
Conversation
| days or less than 30 seconds from the current time, they are considered to be | ||
| restricted forever. | ||
| permissions (:class:`telegram.ChatPermissions`): New user permissions. | ||
| permissions (:class:`telegram.ChatPermissions`): A JSON-serialized object for new user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But uhm, in our context, it would be a JSON- deserialized Telegram class/object. Since we convert it from the string to our own object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just followed the convention to copy official docs. We have a bunch of similar docstrings … I'm fairly sure that passing json data would indeed also work
* Fix PicklePersistence.flush() with only bot_data (#2017) * Update pylint in pre-commit to fix CI (#2018) * Add Filters.via_bot (#2009) * feat: via_bot filter also fixing a small mistake in the empty parameter of the user filter and improve docs slightly * fix: forgot to set via_bot to None * fix: redoing subclassing to copy paste solution * Cosmetic changes Co-authored-by: Hinrich Mahler <hinrich.mahler@freenet.de> * Update CHANGES.rst Fixed Typo Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de> Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
Replaced RegexHandler with MessageHandler, since the former is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)
True, False, None are now rendered with ``bool`` wherever they weren't in telegram and telegram.ext classes.
As usual, docs were cross-checked with official tg api docs.
As usual, docs were cross-checked with official tg api docs.
Mostly just added hyperlinks. And fixed message length doc. As usual, docs were cross-checked with official tg api docs.
Didn't bother changing too much since this seems to be a custom implementation.
As usual, cross-checked with official bot api docs.
Poolitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is good!
Few tiny other fixes too.
Few tiny other doc fixes too.
Lot of doc fixes
restrict_chat_membersargumentchat_permissionfollowing official API docssend_invoicesargumentprovider_datafollowing official API docs