Add missing shortcuts #2043
Merged
Add missing shortcuts #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Agree with that |
Poolitzer
requested changes
Aug 12, 2020
Member
Poolitzer
left a comment
There was a problem hiding this comment.
Good PR, I cant believe we missed .pin()
harshil21
reviewed
Aug 13, 2020
Bibo-Joshi
added a commit
that referenced
this pull request
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, there where a lot more than I expected.
Chatalready has a methodsend_action. I addedsend_chat_actionfor completeness and both toUser.TL;DR: Both. Both is good.
I guess the logic was to skip the
chatsimilarly toMessage.edit_textas shortcut forBot.edit_message_text, but thechatinsend_chat_actionacutally comes from the class nameChatAction… But having both doesn't hurt.Also, one could think of adding shortcuts to
ChosenInlineResult, which has aninline_message_idattribute, but IMHO that doesn't really make sense. It would only be needed, if one would edit the message right after it's posted (why, though?). In all other cases one usually has only theinline_message_idand not theCIR.Closes #2034