Add a basic DDS image plugin with more tests #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supports DXT1 and DXT5 for now. The pixel formats ideally should be supported in decode.c instead, but for now this is good enough. Fixes python-pillow#252
Member
Author
|
Currently failing: |
Contributor
|
The test images display fine for me. |
Member
Author
|
Still a couple more bits -- sanity checks on lengths and io errors on failed unpacks. |
Member
Author
|
Ok, I think I'm good here. This includes #1650, so I'm closing it now. |
hugovk
added a commit
that referenced
this pull request
Jan 16, 2016
Add a basic DDS image plugin with more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With tests comparing the read files to png versions. See #1650