Add a basic DDS image plugin with tests #1650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supports DXT1 and DXT5 for now. The pixel formats ideally should be supported in decode.c instead, but for now this is good enough. Fixes python-pillow#252
Member
Author
|
Should |
Contributor
|
Like I was telling @wiredfool the other day, dxt1 and dxt5 should be implemented as pixel formats in But yeah the plugin I provided is meant to be a starting point. |
Member
Author
|
Yep, might be an idea to add that as TODOs in the code for now. Edit: Added TODOs and underscores. |
Contributor
|
I filed the todo in #1652 where it won't bitrot. Consider squashing some of your commits but the code looks good. |
Member
|
See #1654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #1644 by @jleclanche.
Add unit tests with @Metallicow's test images from #1644 (comment) ("License CC0/Public domain/PIL whatever").
I just picked the smallest of each image format.
DdsImagePlugin.py is now 97.59% covered; just four lines uncovered. They could perhaps be exercised with other test images.
Closes #1644 and fixes #252.