Only validate unevaluated properties/items on applicable types#949
Merged
Julian merged 3 commits intopython-jsonschema:mainfrom May 20, 2022
Merged
Only validate unevaluated properties/items on applicable types#949Julian merged 3 commits intopython-jsonschema:mainfrom
Julian merged 3 commits intopython-jsonschema:mainfrom
Conversation
Member
|
Thanks! The tests for this would actually belong first as a pull request to the official test suite. Could you perhaps give that a shot? |
Contributor
Author
|
Julian
added a commit
that referenced
this pull request
May 18, 2022
Member
|
Thanks! I've pulled those in here (and skipped them on master -- so you should be able to unskip them here in a commit and see these pass.) Appreciated. |
… is merged." This reverts commit 8223a95.
Contributor
Author
|
@Julian that's done. Feel free to review and merge |
Member
|
Great! Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes attribute error when trying to validate
unevaluatedPropertiesandunevaluatedItemson objects which aren't adictorlistrespectively.