Skip to content

Fix some errors with --disallow-any-generics#3276

Merged
gvanrossum merged 13 commits intomasterfrom
disallow-any-generics
Sep 29, 2019
Merged

Fix some errors with --disallow-any-generics#3276
gvanrossum merged 13 commits intomasterfrom
disallow-any-generics

Conversation

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 28, 2019

Trying to help with #3267. I'm tackling all of stdlib/2and3 (and done with that now).

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srittau
Copy link
Collaborator

srittau commented Sep 29, 2019

pytype is complaining about Union in shutil, so maybe try to move None out of the IgnoreFn union? Also cc @rchen152

Edit: Or just inline _IgnoreFn, since each alias is only used once anyway.

srittau added a commit to srittau/typeshed that referenced this pull request Sep 29, 2019
Part of python#3267. Together with python#3276 this should fix all such problems.
@gvanrossum gvanrossum merged commit b336182 into master Sep 29, 2019
@gvanrossum gvanrossum deleted the disallow-any-generics branch September 29, 2019 16:18
JelleZijlstra pushed a commit that referenced this pull request Sep 30, 2019
Part of #3267. Together with #3276 this should fix all such problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants