Fix third_party errors with --disallow-any-generics#3278
Merged
JelleZijlstra merged 10 commits intopython:masterfrom Sep 30, 2019
Merged
Fix third_party errors with --disallow-any-generics#3278JelleZijlstra merged 10 commits intopython:masterfrom
JelleZijlstra merged 10 commits intopython:masterfrom
Conversation
Part of python#3267. Together with python#3276 this should fix all such problems.
JelleZijlstra
requested changes
Sep 30, 2019
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks for doing all this! I'm concerned that some of the changes to IO-like classes can lead to new false positives (comments inline).
Collaborator
Author
|
@JelleZijlstra I think I changed everything that needed to be changed. |
JelleZijlstra
approved these changes
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3267. Together with #3276 this should fix all such problems.
I mostly used
Anyannotations. These can often be improved with more specific types.