Updated core handlers in logging#3269
Merged
srittau merged 1 commit intopython:masterfrom Sep 27, 2019
Merged
Conversation
srittau
approved these changes
Sep 27, 2019
msullivan
added a commit
that referenced
this pull request
Oct 1, 2019
PR #3269 added some version checks for the argument type to setLevel and the existence of NullHandler. While these features weren't present in early versions of Python 3, they *are* present in Python 2.7, which leads to false positives. We could expand the check to include Python 2, but since the affected Python 3 versions are super old and unsupported, I'm just removing the checks.
srittau
pushed a commit
that referenced
this pull request
Oct 2, 2019
PR #3269 added some version checks for the argument type to setLevel and the existence of NullHandler. While these features weren't present in early versions of Python 3, they *are* present in Python 2.7, which leads to false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated/slightly corrected several type annotations in the
loggingmodule, primarily surrounding the built-in handlers (which are confusingly documented with thelogging.handlersmodule). The most significant changes are the addition of theStreamHandler.setStreammethod (new as of 3.7) and makingFileHandlera proper subclass ofStreamHandler—it's documented as such (and, well, implemented as such), so I have to assume it's just an oversight in the stub. I don't think there's anything too controversial there.