Remove some spurious version checks in logging#3292
Merged
Conversation
PR #3269 added some version checks for the argument type to setLevel and the existence of NullHandler. While these features weren't present in early versions of Python 3, they *are* present in Python 2.7, which leads to false positives. We could expand the check to include Python 2, but since the affected Python 3 versions are super old and unsupported, I'm just removing the checks.
srittau
approved these changes
Oct 2, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
In the past we have removed version checks for unsupported Python versions for easier readability of the stubs, so this is consistent with that decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3269 added some version checks for the argument type to setLevel
and the existence of NullHandler. While these features weren't present
in early versions of Python 3, they are present in Python 2.7, which
leads to false positives.
We could expand the check to include Python 2, but since the affected
Python 3 versions are super old and unsupported, I'm just removing the
checks.