Conversation
srittau
left a comment
There was a problem hiding this comment.
Not a thorough review yet, but please note that AnyStr is not an alias for Union[Text, bytes]. If you need something like that, you need to define it yourself or annotate it like this inline. An alias would be useful, since the argument type is used many locations and actually includes some more types, so it can be expanded later.
e569ac5 to
7b07a6b
Compare
|
As discussed on Gitter, I fixed the types for the "string-like" parameters. |
7b07a6b to
b917837
Compare
srittau
left a comment
There was a problem hiding this comment.
Thanks, just one comment.
b917837 to
8b016fe
Compare
|
Will merge when tests pass. Just for future reference: Please don't force-push as it makes it harder to review changes. |
Oh, ok. Other projects I contribute to tend to prefer force pushing so the merged history is clean, but I'm happy to adapt. 🙂 Thanks for the review and for the help! |
I need it for the Redis type stub improvements in master. python/typeshed#3015 python/typeshed#3016 python/typeshed#3055
I need it for the Redis type stub improvements in master. python/typeshed#3015 python/typeshed#3016 python/typeshed#3055
Note that I only tested
brpopandlpush, but I figured I'd do the other two as well since they are symmetric.