Merged
Conversation
Contributor
|
FWIW, this seems to work great at least in my use-case. 🙂 |
JelleZijlstra
requested changes
Jun 12, 2019
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Sorry for missing this! I have a few comments
| ssl_keyfile: Optional[Text] = ..., | ||
| ssl_certfile: Optional[Text] = ..., | ||
| ssl_cert_reqs: Optional[Union[str, int]] = ..., | ||
| ssl_ca_certs: Optional[Text] = ..., |
Member
There was a problem hiding this comment.
Missing the max_connections=None argument (https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L635).
third_party/2and3/redis/client.pyi
Outdated
| self, | ||
| name: Text, | ||
| value: Any, | ||
| ex: Optional[int] = ..., |
Member
There was a problem hiding this comment.
ex and px can also be timedeltas
Collaborator
Author
|
@JelleZijlstra Thanks, done! |
JelleZijlstra
approved these changes
Jun 12, 2019
joejuzl
reviewed
Jun 12, 2019
| def set(self, name, value, ex=..., px=..., nx=..., xx=...): ... | ||
| def set( | ||
| self, | ||
| name: Text, |
Contributor
There was a problem hiding this comment.
I think name (here and in the other methods too) can be either str or bytes.
bochecha
added a commit
to HashBangCoop/mypy
that referenced
this pull request
Jun 12, 2019
I need python/typeshed#3016 which is merged in typeshed, but mypy upstream hasn't updated their submodule yet.
bochecha
added a commit
to HashBangCoop/mypy
that referenced
this pull request
Jun 14, 2019
bochecha
added a commit
to HashBangCoop/mypy
that referenced
this pull request
Jun 24, 2019
I need it for the Redis type stub improvements in master. python/typeshed#3015 python/typeshed#3016 python/typeshed#3055
bochecha
added a commit
to HashBangCoop/mypy
that referenced
this pull request
Jun 28, 2019
I need it for the Redis type stub improvements in master. python/typeshed#3015 python/typeshed#3016 python/typeshed#3055
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.