Fix mypy pretty output within a pty#8145
Merged
msullivan merged 2 commits intopython:masterfrom Dec 14, 2019
asottile:pty_terminal_size
Merged
Fix mypy pretty output within a pty#8145msullivan merged 2 commits intopython:masterfrom asottile:pty_terminal_size
msullivan merged 2 commits intopython:masterfrom
asottile:pty_terminal_size
Conversation
Collaborator
|
This looks good and is a good catch. The test strikes me as super marginal though, so let's just skip adding it. |
Contributor
Author
|
deleted the test, seems weird to not have a regression test for this fix but that's not my call! |
emmatyping
approved these changes
Dec 13, 2019
Collaborator
|
I think an integration test to catch a regression here could be useful but it doesn't seem super useful to me to have a unit test that just recapitulates the code in a straightforward way? |
Contributor
Author
|
looks like I should have added a test as this has regressed: https://github.com/pre-commit/mirrors-mypy/issues/29 |
JukkaL
pushed a commit
that referenced
this pull request
Oct 28, 2020
Contrary to what I assumed in #9143, shutil.get_terminal_size() doesn't actually handle a 0 width from os.get_terminal_size() - it only handles a 0 COLUMNS environment variable. Thus, this caused #8144 to regress. This change re-adds and uses DEFAULT_COLUMNS and also adds the test which was deemed unnecessary in #8145 - this regression proves that I'd have been a good idea to add it in the first place. (Test written by Anthony Sottile) Fixes https://github.com/pre-commit/mirrors-mypy/issues/29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8144
here's the same script that was used in the reproduction for #8144: