Re-add fallback for zero terminal width#9651
Merged
JukkaL merged 1 commit intopython:masterfrom Oct 28, 2020
The-Compiler:columns-fallback
Merged
Re-add fallback for zero terminal width#9651JukkaL merged 1 commit intopython:masterfrom The-Compiler:columns-fallback
JukkaL merged 1 commit intopython:masterfrom
The-Compiler:columns-fallback
Conversation
Contrary to what I assumed in #9143, shutil.get_terminal_size() doesn't actually handle a 0 width from os.get_terminal_size() - it only handles a 0 COLUMNS environment variable. Thus, this caused #8144 to regress. This change re-adds and uses DEFAULT_COLUMNS and also adds the test which was deemed unnecessary in #8145 - this regression proves that I'd have been a good idea to add it in the first place. (Test written by Anthony Sottile) Fixes https://github.com/pre-commit/mirrors-mypy/issues/29
Contributor
Author
|
FWIW I also opened a Python bug about this now, since I feel like |
JukkaL
approved these changes
Oct 28, 2020
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for the fix! This is clearly an area with some tricky edge cases, so adding a test makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to what I assumed in #9143, shutil.get_terminal_size() doesn't
actually handle a 0 width from os.get_terminal_size() - it only handles
a 0 COLUMNS environment variable.
Thus, this caused #8144 to regress.
This change re-adds and uses DEFAULT_COLUMNS and also adds the test
which was deemed unnecessary in #8145 - this regression proves that I'd
have been a good idea to add it in the first place.
(Test written by Anthony Sottile)
Fixes https://github.com/pre-commit/mirrors-mypy/issues/29