bpo-44686 replace unittest.mock._importer with pkgutil.resolve_name by graingert · Pull Request #18544 · python/cpython

graingert · 2020-02-18T10:06:17Z

https://bugs.python.org/issue44686

Automerge-Triggered-By: GH:cjw296

codecov · 2020-02-18T10:36:14Z

Codecov Report

Merging #18544 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18544      +/-   ##
==========================================
- Coverage   83.25%   83.20%   -0.06%     
==========================================
  Files        1571     1571              
  Lines      414749   414735      -14     
  Branches    44456    44453       -3     
==========================================
- Hits       345300   345068     -232     
- Misses      59795    60019     +224     
+ Partials     9654     9648       -6

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edfc47...077c3bc. Read the comment docs.

tirkarthi · 2020-02-19T16:29:53Z

I think this deserves a discussion and a bpo. @cjw296 this uses pkgutil.resolve_name which is a new feature in 3.9 and the backport needs to accommodate the change if merged.

FFY00 · 2020-05-20T22:00:53Z

Lib/unittest/mock.py

                        (target,))
-    getter = lambda: _importer(target)
-    return getter, attribute
+    return partial(pkgutil.resolve_name, target), attribute


Is there any reason here to be using functools.partial over lambda?

for consistency. lambda: is used twice in this file whereas partial( is used six times

cjw296 · 2020-05-21T06:44:06Z

@tirkarthi: Looking at the diff, we could probably just skip backporting this one...

graingert · 2021-07-20T19:50:31Z

I think this deserves a discussion and a bpo. @cjw296 this uses pkgutil.resolve_name which is a new feature in 3.9 and the backport needs to accommodate the change if merged.

I've now created the bpo

Misc/NEWS.d/next/Library/2021-07-20-19-35-49.bpo-44686.ucCGhu.rst

miss-islington · 2021-07-21T08:03:51Z

@graingert: Status check is done, and it's a success ❌ .

miss-islington · 2021-07-21T11:30:02Z

@graingert: Status check is done, and it's a success ✅ .

miss-islington · 2021-07-21T11:30:04Z

Sorry, I can't merge this PR. Reason: 3 of 5 required status checks have not succeeded: 1 expected..

miss-islington · 2021-07-21T11:47:43Z

@graingert: Status check is done, and it's a success ✅ .

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: #112317

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. X-original-commit: 482cb08

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. X-original-commit: 482cb08 Part-of: #112440

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: #112450

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: odoo#112317

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.

Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: #151989

Damn, python/cpython#18544 actually changed the behavior.

J08nY · 2025-10-17T14:18:43Z

Hi all, sorry to resurrect a very old PR. However, this change actually changed the behavior of the lookup used in the mockers. A clear example is given here: scikit-hep/pyhf#2143 (comment).

I wonder if the Python docs for unittest could be changed to include information about the changed behavior. However, I am not sure how to describe the actual changes.

replace unittest.mock._importer with pkgutil.resolve_name

077c3bc

the-knights-who-say-ni added the CLA signed label Feb 18, 2020

bedevere-bot added the awaiting review label Feb 18, 2020

FFY00 reviewed May 20, 2020

View reviewed changes

Merge branch 'main' into patch-3

2f93c52

graingert requested a review from cjw296 as a code owner July 20, 2021 19:22

graingert changed the title ~~replace unittest.mock._importer with pkgutil.resolve_name~~ bpo-44686 replace unittest.mock._importer with pkgutil.resolve_name Jul 20, 2021

graingert and others added 2 commits July 20, 2021 20:34

fix merge resolution

c4f43c9

📜🤖 Added by blurb_it.

e9485d6

graingert requested a review from FFY00 July 20, 2021 19:49

cjw296 approved these changes Jul 21, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 21, 2021

cjw296 reviewed Jul 21, 2021

View reviewed changes

Misc/NEWS.d/next/Library/2021-07-20-19-35-49.bpo-44686.ucCGhu.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2021-07-20-19-35-49.bpo-44686.ucCGhu.rst

cf25db4

cjw296 added the 🤖 automerge label Jul 21, 2021

miss-islington merged commit ab7fcc8 into python:main Jul 21, 2021

bedevere-bot removed the awaiting merge label Jul 21, 2021

graingert deleted the patch-3 branch July 21, 2021 11:48

sthagen mentioned this pull request Jul 21, 2021

bpo-44686 replace unittest.mock._importer with pkgutil.resolve_name (… sthagen/python-cpython#549

Merged

graingert mannequin mentioned this pull request Apr 10, 2022

use pkgutil.resolve_name in unittest.mock #88852

Open

wookie184 mentioned this pull request Mar 21, 2023

Bump python version to 3 11 python-discord/bot#2432

Merged

This was referenced Jul 24, 2023

[Packaging] Support Python 3.11 Azure/azure-cli#26923

Merged

mocker.patch fails to find tensorlib _setup attribute for Python 3.11 scikit-hep/pyhf#2143

Closed

J08nY added a commit to crocs-muni/sec-certs that referenced this pull request Oct 17, 2025

Fix Python 3.10 tests.

8c0e52c

Damn, python/cpython#18544 actually changed the behavior.

dbari mentioned this pull request Mar 16, 2026

[Bugfix] Fix mock.patch resolution failure for standalone_compile.FakeTensorMode on Python <= 3.10 vllm-project/vllm#37158

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bpo-44686 replace unittest.mock._importer with pkgutil.resolve_name#18544

bpo-44686 replace unittest.mock._importer with pkgutil.resolve_name#18544
miss-islington merged 5 commits intopython:mainfrom
graingert:patch-3

graingert commented Feb 18, 2020 •

edited by miss-islington

Loading

Uh oh!

codecov bot commented Feb 18, 2020

Uh oh!

tirkarthi commented Feb 19, 2020

Uh oh!

FFY00 May 20, 2020

Uh oh!

graingert Jul 20, 2021

Uh oh!

cjw296 commented May 21, 2020

Uh oh!

graingert commented Jul 20, 2021

Uh oh!

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

J08nY commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

graingert commented Feb 18, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 18, 2020

Codecov Report

Uh oh!

tirkarthi commented Feb 19, 2020

Uh oh!

FFY00 May 20, 2020

Choose a reason for hiding this comment

Uh oh!

graingert Jul 20, 2021

Choose a reason for hiding this comment

Uh oh!

cjw296 commented May 21, 2020

Uh oh!

graingert commented Jul 20, 2021

Uh oh!

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

miss-islington commented Jul 21, 2021

Uh oh!

J08nY commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

graingert commented Feb 18, 2020 •

edited by miss-islington

Loading