Skip to content

[FIX] *: adapt for noble#151989

Closed
Xavier-Do wants to merge 17 commits intoodoo:15.0from
odoo-dev:15.0-noble-xdo
Closed

[FIX] *: adapt for noble#151989
Xavier-Do wants to merge 17 commits intoodoo:15.0from
odoo-dev:15.0-noble-xdo

Conversation

@Xavier-Do
Copy link
Copy Markdown
Contributor

@Xavier-Do Xavier-Do commented Jan 31, 2024

This pr backports some fixed for python3.11 and introduces new fixes for Ubuntu Noble, such as timezones.

@robodoo
Copy link
Copy Markdown
Contributor

robodoo commented Jan 31, 2024

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 31, 2024
@Xavier-Do Xavier-Do force-pushed the 15.0-noble-xdo branch 3 times, most recently from 17f3431 to 64aad99 Compare January 31, 2024 13:23
@Xavier-Do Xavier-Do force-pushed the 15.0-noble-xdo branch 2 times, most recently from cbda90f to 67c86d2 Compare March 13, 2024 09:27
@Xavier-Do Xavier-Do changed the title [FIX] *: get rid of werkzeug.urls [FIX] *: adapt werkzeug.urls for noble Mar 13, 2024
@Xavier-Do Xavier-Do marked this pull request as ready for review March 13, 2024 11:55
@C3POdoo C3POdoo requested review from a team, Julien00859, sleepy-monax and xmo-odoo and removed request for a team March 13, 2024 11:56
@Xavier-Do
Copy link
Copy Markdown
Contributor Author

Xavier-Do commented Mar 13, 2024

@odoo/rd-security

Eit: Nevermind this won't be enough, will need to vendor urls I think

@Xavier-Do Xavier-Do marked this pull request as draft March 13, 2024 12:22
@Xavier-Do Xavier-Do force-pushed the 15.0-noble-xdo branch 3 times, most recently from 31132f1 to 4beb0d9 Compare March 13, 2024 15:08
@Xavier-Do Xavier-Do force-pushed the 15.0-noble-xdo branch 2 times, most recently from c6584fd to f5fd7c2 Compare March 14, 2024 09:27
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 2, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

2 similar comments
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 3, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 4, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 5, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 6, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 7, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 8, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

@nmarotte
Copy link
Copy Markdown
Contributor

nmarotte commented Apr 8, 2024

Hello, @Xavier-Do , I believe this PR breaks a test here :

assertTZEqual(pytz.timezone(source), pytz.timezone(target))

image

You can view an example on the branch 17.0-run-tests of this DB https://logipren.odoo.com/_odoo/support/

@Xavier-Do
Copy link
Copy Markdown
Contributor Author

We will check that, you can disable this test waiting for a fix :)

@nmarotte
Copy link
Copy Markdown
Contributor

nmarotte commented Apr 8, 2024

Perfect thanks ! I'm not in a hurry so it's fine, I'm happy to know you guys are going to take a look :)

@Xavier-Do
Copy link
Copy Markdown
Contributor Author

Perfect thanks ! I'm not in a hurry so it's fine, I'm happy to know you guys are going to take a look :)

We made a fix pr to make the test more robust, we are still investigating to understand why this tz is missing on odoosh but the purpose of this test is mainly to check that the mapping gives the same result if both tz exists. So once #160868 is merged the issue should be solved, tell us if the problem persist after that :)

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Apr 10, 2024

@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed):

@amh-mw
Copy link
Copy Markdown
Contributor

amh-mw commented Apr 10, 2024

Hello, @Xavier-Do , I believe this PR breaks a test here :

This made it into the most recent odoo:15 docker image, suggesting that the release process does not ensure that only ✅ docker images are published.

@d-fence
Copy link
Copy Markdown
Contributor

d-fence commented Apr 10, 2024

Hello, @Xavier-Do , I believe this PR breaks a test here :

This made it into the most recent odoo:15 docker image, suggesting that the release process does not ensure that only ✅ docker images are published.

The official docker images are not made to run tests, a lot of tools are missing on the images to do that.

@amh-mw
Copy link
Copy Markdown
Contributor

amh-mw commented Apr 10, 2024

The official docker images are not made to run tests, a lot of tools are missing on the images to do that.

Right, but if the tests failed, why was the image created?

@Xavier-Do
Copy link
Copy Markdown
Contributor Author

The test only fails if the os is in a particular state. After our investigation it was more a mistake in the tzdata package.
The docker image is build automaticaly, the test are not ran, it is not the purpose of this image. The image is valid, even with this failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants