[IMP] base: fix test_tz to work if target is missing#160868
Closed
[IMP] base: fix test_tz to work if target is missing#160868
Conversation
The test test_tz_legacy will fail if the taget does not exist on the operating system. This is breaking in some versions of the tz-data package. Don't make this test fail if the target is missing.
Contributor
|
robodoo r+ |
Contributor
robodoo
pushed a commit
that referenced
this pull request
Apr 10, 2024
The test test_tz_legacy will fail if the taget does not exist on the operating system. This is breaking in some versions of the tz-data package. Don't make this test fail if the target is missing. closes #160868 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
This was referenced Apr 10, 2024
Xavier-Do
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 11, 2024
The test test_tz_legacy will fail if the taget does not exist on the operating system. This is breaking in some versions of the tz-data package. Don't make this test fail if the target is missing. closes odoo#160868 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 11, 2024
The test test_tz_legacy will fail if the taget does not exist on the operating system. This is breaking in some versions of the tz-data package. Don't make this test fail if the target is missing. closes #160868 closes #160853 Related: odoo/enterprise#60224 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com> Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See #151989 (comment)
The test test_tz_legacy will fail if the taget does not exist on the operating system.
This is breaking in some versions of the tz-data package.
Don't make this test fail if the target is missing.