Skip to content

Conversation

@ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented May 21, 2019

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jaraco
Copy link
Member

jaraco commented May 22, 2019

Is there any value in leaving an orphaned 'packageindex.rst', given that we can always reference it at a permalink prior to acceptance of this change?

@ncoghlan ncoghlan merged commit e788057 into python:master May 23, 2019
@miss-islington
Copy link
Contributor

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@ncoghlan: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot
Copy link

GH-13524 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2019
…ythonGH-13462)

(cherry picked from commit e788057)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
miss-islington added a commit that referenced this pull request May 23, 2019
…H-13462)

(cherry picked from commit e788057)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants