Skip to content

gh-122781: Fix %z in strptime#132922

Merged
pganssle merged 2 commits into
python:mainfrom
StanFromIreland:strptime-fix-z
May 20, 2025
Merged

gh-122781: Fix %z in strptime#132922
pganssle merged 2 commits into
python:mainfrom
StanFromIreland:strptime-fix-z

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Alternate (simpler) approach than old pr: #122829 by just updating the regex (and testing it this time).

@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2025
Closed
@StanFromIreland StanFromIreland mentioned this pull request Apr 25, 2025
Closed
@StanFromIreland

StanFromIreland commented Apr 25, 2025

Copy link
Copy Markdown
Member Author

Test fails are unrelated.

pganssle
pganssle requested changes May 20, 2025
View reviewed changes

@pganssle pganssle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good approach, just a nit about how to do the tests and also want to make sure %:z is covered as well.

Comment thread Lib/test/datetimetester.py Outdated
Comment thread Lib/test/datetimetester.py Outdated
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland

StanFromIreland commented May 20, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from pganssle May 20, 2025 15:53
@pganssle pganssle enabled auto-merge (squash) May 20, 2025 16:19
@pganssle pganssle merged commit 99b5808 into python:main May 20, 2025
44 of 47 checks passed
@StanFromIreland StanFromIreland deleted the strptime-fix-z branch May 20, 2025 16:48
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@StanFromIreland @lkollar
pythongh-122781: Allow empty offset for %z in strptime (python#13…
09304a6 
…2922)

* commit

* Move tests
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-122781: Allow empty offset for %z in strptime (python#13…
2854310 
…2922)

* commit

* Move tests
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @taegyunkim
pythongh-122781: Allow empty offset for %z in strptime (python#13…
9007029 
…2922)

* commit

* Move tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes

@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @pganssle