Skip to content

gh-122781: fix time format bug#122829

Closed
midnightstardust wants to merge 3 commits into
python:mainfrom
midnightstardust:FixDateIssue
Closed

gh-122781: fix time format bug#122829
midnightstardust wants to merge 3 commits into
python:mainfrom
midnightstardust:FixDateIssue

Conversation

@midnightstardust

@midnightstardust midnightstardust commented Aug 8, 2024

Copy link
Copy Markdown

Fixed it such that %z is now read as optional and can be an empty string.

@bedevere-app

bedevere-app Bot commented Aug 8, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@@ -0,0 +1 @@
Make %z represent an optional UTC offset instead of mandating a UTC offset

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate NEWS

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and remove the duplicate NEWS entry.

I have proposed a simpler approach in: #132922

@donbarbos

Copy link
Copy Markdown
Contributor

@StanFromIreland apparently you can now close this PR since the issue has been resolved

@StanFromIreland

Copy link
Copy Markdown
Member

Thank you, yes this was fixed with #132922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants