Skip to content

Release 4.5.0#5246

Merged
nicoddemus merged 173 commits into
pytest-dev:masterfrom
nicoddemus:release-4.5.0
May 12, 2019
Merged

Release 4.5.0#5246
nicoddemus merged 173 commits into
pytest-dev:masterfrom
nicoddemus:release-4.5.0

Conversation

@nicoddemus

Copy link
Copy Markdown
Member

No description provided.

blueyed and others added 30 commits March 29, 2019 11:13
Co-Authored-By: Zac-HD <Zac-HD@users.noreply.github.com>
Pre-PR for warnings on unknown markers
So that we can ignore it in self-tests.
Emit warning on unknown marks via decorator
…g_at_shutdown

capture: do not set logging.raiseExceptions = False
pdb: add option to skip `pdb.set_trace()`
…-code

wrap_session: restore old behavior for initstate=1
…to-features

Merge master into features (with regen)
nicoddemus and others added 23 commits May 5, 2019 21:33
…5204)

Emit a warning for record_property when used with xunit2
…ytest-dev#5221)

Show fixture scopes with ``--fixtures``, except for "function" scope
We improve the following things in the logging format:

  * Show module name instead of just the filename
  * show level of logging as the first thing
  * show lineno attached to module:file details

Thanks to @blueyed who suggested this on the github issue.

It's my first contribution and I have added myself to AUTHORS.

I also added to a changelog file.
logging: improve default logging format (issue5214)
Display message from reprcrash in short test summary
A lot of our examples use custom markers to make a point and showcase
features, which generates a lot of warnings
Ignore PytestUnknownMark warning when generating docs
pdb: only use outcomes.exit via do_quit
It doesn't seem to add much value (why would one execute tests
based on that marker?), plus using the docstring for that
encourages one to write a more descriptive message about the test
This exposes the functionality introduced in fa6acdc as a session-scoped fixture.

Plugins that want to remain compatible with the `xunit2`
standard should use this fixture instead of `record_property`.

Fix pytest-dev#5202
Introduce record_testsuite_property fixture
Further "unknown marks warning" improvements
@codecov

codecov Bot commented May 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5246 into master will decrease coverage by 2.33%.
The diff coverage is 97.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5246      +/-   ##
==========================================
- Coverage   96.06%   93.73%   -2.34%     
==========================================
  Files         114      115       +1     
  Lines       25823    26159     +336     
  Branches     2550     2578      +28     
==========================================
- Hits        24808    24520     -288     
- Misses        705     1321     +616     
- Partials      310      318       +8
Impacted Files Coverage Δ
testing/test_skipping.py 97.47% <ø> (-0.18%) ⬇️
testing/test_tmpdir.py 98.92% <ø> (ø) ⬆️
src/_pytest/runner.py 98.01% <ø> (-0.01%) ⬇️
testing/test_recwarn.py 99.57% <ø> (ø) ⬆️
testing/test_conftest.py 99.62% <ø> (-0.01%) ⬇️
testing/python/metafunc.py 93.01% <ø> (-2.23%) ⬇️
testing/logging/test_reporting.py 100% <ø> (ø) ⬆️
testing/python/integration.py 91.42% <ø> (-0.07%) ⬇️
src/_pytest/skipping.py 96.15% <ø> (+0.59%) ⬆️
src/_pytest/hookspec.py 100% <ø> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccaa98...63fe547. Read the comment docs.

@nicoddemus

Copy link
Copy Markdown
Member Author

Weird, the codecov is clearly incorrect: coverage was posted before Travis even started.

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueyed

blueyed commented May 11, 2019

Copy link
Copy Markdown
Contributor

Weird, the codecov is clearly incorrect:

Seen this with some recent PR of mine also already - re-triggered the build a few times, but gave up then.
Let's see how it looks when merged.

@blueyed blueyed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

Comment thread CHANGELOG.rst

- `#5023 <https://github.com/pytest-dev/pytest/issues/5023>`_: New flag ``--strict-markers`` that triggers an error when unknown markers (e.g. those not registered using the `markers option`_ in the configuration file) are used in the test suite.

The existing ``--strict`` option has the same behavior currently, but can be augmented in the future for additional checks.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicoddemus nicoddemus merged commit 6a43c8c into pytest-dev:master May 12, 2019
@nicoddemus nicoddemus deleted the release-4.5.0 branch May 12, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants